Merged
Conversation
plamut
approved these changes
Jun 9, 2020
plamut
reviewed
Jun 9, 2020
Contributor
There was a problem hiding this comment.
Wait, where is #108?
Answer: The bot did not recognize the type of that PR and did not include it in the release notes, we will edit them manually.
Update: Actually, the bot only included 2 of the 6 commits added since the 1.5.0 release...
plamut
suggested changes
Jun 9, 2020
Contributor
plamut
left a comment
There was a problem hiding this comment.
We need to update a few URLs...
pradn
approved these changes
Jun 9, 2020
plamut
approved these changes
Jun 9, 2020
4 tasks
Contributor
Contributor
|
@plamut The bot is configured to only add commits of type |
Contributor
|
@busunkim96 That would make sense, probably at least Maybe adding a note / warning to the PR description would also be helpful to remind reviewers that CHANGELOG might not include all the commits and should be double-checked? |
This was referenced Jun 11, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.6.0 (2020-06-09)
Features
Bug Fixes
Documentation
Internal / Testing Changes